Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4d SO3 optimizer #90

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

keefemitman
Copy link
Contributor

@keefemitman keefemitman commented Jul 15, 2024

Extend align2d to optimize over the full SO(3) transformation (as well as the time translation).


📚 Documentation preview 📚: https://sxs--90.org.readthedocs.build/en/90/

@keefemitman
Copy link
Contributor Author

keefemitman commented Jul 16, 2024

After talking with @duetosymmetry I'll change the optimization space to be over quaternion components

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 4.65116% with 82 lines in your changes missing coverage. Please review.

Project coverage is 42.22%. Comparing base (85f905f) to head (7ee0d91).

Files with missing lines Patch % Lines
sxs/waveforms/alignment.py 4.65% 82 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   42.65%   42.22%   -0.43%     
==========================================
  Files          80       80              
  Lines        6731     6806      +75     
  Branches     1075     1087      +12     
==========================================
+ Hits         2871     2874       +3     
- Misses       3614     3686      +72     
  Partials      246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sxs/waveforms/alignment.py Outdated Show resolved Hide resolved
sxs/waveforms/alignment.py Show resolved Hide resolved
sxs/waveforms/alignment.py Show resolved Hide resolved
sxs/waveforms/alignment.py Outdated Show resolved Hide resolved
sxs/waveforms/alignment.py Outdated Show resolved Hide resolved
sxs/waveforms/alignment.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants