-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LVC integration #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 42.22% 40.70% -1.53%
==========================================
Files 71 73 +2
Lines 5579 5950 +371
Branches 1236 1222 -14
==========================================
+ Hits 2356 2422 +66
- Misses 3017 3308 +291
- Partials 206 220 +14 ☔ View full report in Codecov by Sentry. |
moble
force-pushed
the
lvc_integration
branch
2 times, most recently
from
April 29, 2024 19:15
a236a52
to
9bc45c6
Compare
Signed-off-by: Mike Boyle <[email protected]>
Signed-off-by: Mike Boyle <[email protected]>
Signed-off-by: Mike Boyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of commits
This should create a new #major version
to_lvc_conventions
andload_lvc
group
kwarg through to rpdmb.load; closes sxs.load('...') fails for ExtraWaveforms.h5 #80sxs.load
with git-annex #84Remaining tasks
I'm not sure how much these really need to be done before the code is merged, but these would be good:
📚 Documentation preview 📚: https://sxs--89.org.readthedocs.build/en/89/