Fix coroutine lock core tests, remove useless code. --filter=[core]

swoole · Dec 31, 2024 · 1a40cd5 · 1a40cd5
1 parent 4cb03b4
commit 1a40cd5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/core-tests/src/lock/lock.cpp b/core-tests/src/lock/lock.cpp
@@ -140,7 +140,7 @@ TEST(lock, try_rd) {
 }
 
 TEST(lock, coroutine_lock) {
-    CoroutineLock *lock = new CoroutineLock();
+    CoroutineLock *lock = new CoroutineLock(false);
     ASSERT_EQ(lock->lock(), SW_ERROR_CO_OUT_OF_COROUTINE);
     auto callback = [lock]() {
         coroutine::run([lock](void *arg) {

diff --git a/ext-src/swoole_coroutine_lock.cc b/ext-src/swoole_coroutine_lock.cc
@@ -134,14 +134,3 @@ static PHP_METHOD(swoole_coroutine_lock, trylock) {
     CoroutineLock *lock = co_lock_get_and_check_ptr(ZEND_THIS);
     SW_LOCK_CHECK_RETURN(lock->trylock());
 }
-
-static PHP_METHOD(swoole_coroutine_lock, trylock_read) {
-    CoroutineLock *lock = co_lock_get_and_check_ptr(ZEND_THIS);
-    SW_LOCK_CHECK_RETURN(lock->trylock_rd());
-}
-
-static PHP_METHOD(swoole_coroutine_lock, lock_read) {
-    CoroutineLock *lock = co_lock_get_and_check_ptr(ZEND_THIS);
-    SW_LOCK_CHECK_RETURN(lock->lock_rd());
-}
-