Switch to PKG_CHECK_MODULES #65
Conversation
| [Specify version of python, default is 3.11])], [no], [no]) | ||
|
|
||
| PHP_ARG_WITH([python_config], | ||
| [path of python_config], |
There was a problem hiding this comment.
It is necessary to retain the python-config option. When using Anaconda to manage Python, and multiple versions of Python are present, it is essential to utilize absolute paths.
There was a problem hiding this comment.
I don't even know what Anaconda is (seems very distro specific)
BTW, python-config and pkg-config will give you same results. pkg-config is used by PHP since 7.4 for most of the libraries. For non standard installation, setting PKG_CONFIG_PATH is the proper way.
Feel free to keep this PR as a sample of clean config.m4 and adapt to your needs
|
This commit is not forward-compatible and needs further consideration. |
|
Refer to 59c2cb0 |
drop --with-python-config and --with-python-dir option also use EXTRAS_CXXFLAGS instead of changing CXXFLAGS
remicollet
force-pushed
the
issue-pkgconfig
branch
from
7853104 to
13a1d9d
Compare
|
Rebased, but feel free to close and consider it only as a example Notice: default config.m4 doesn't work (as /opt/anaconda3 is used and doesn't exist) |
|
I reviewed your PR and optimized the config.m4. Here's the new commit. |
|
so closing |
|
FYI, for RPM build available to Fedora/RHEL/CentOS/Alma/Rocky... in my repo, I will use So |
drop --with-python-config and --with-python-dir option
also use EXTRAS_CXXFLAGS instead of changing CXXFLAGS