fix core dump when "new PyType" #30

he426100 · 2023-12-26T05:42:55Z

复现代码

$type = new PyType;

修改前运行会coredump，修改后可以抛出异常

Fatal error: Uncaught Error: Call to private PyType::__construct() from global scope in /home/mrpzx/git/phpy/phpy-examples/test.php:3
Stack trace:
#0 {main}
  thrown in /home/mrpzx/git/phpy/phpy-examples/test.php on line 3

he426100 · 2023-12-26T05:54:46Z

ZEND_METHOD(PyType, __construct) {}

查了下，除了type还有iter也是这么写的，new PyIter也会coredump

matyhtf · 2023-12-26T08:33:11Z

应该将构造方法申明为私有，禁止 new PyDict/PyIter

matyhtf

stub 文件也需要提交上来。如果不禁止 new 的话，不光是 dtor 会 coredump，如果调用 $obj->__call 之类的方法也会 coredump

fix core dump when "new PyType"

44f8e93

add test code

aec8327

matyhtf requested changes Dec 26, 2023

View reviewed changes

matyhtf merged commit 84f0b2d into swoole:main Dec 26, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix core dump when "new PyType" #30

fix core dump when "new PyType" #30

he426100 commented Dec 26, 2023

he426100 commented Dec 26, 2023

matyhtf commented Dec 26, 2023

matyhtf left a comment •

edited

Loading

fix core dump when "new PyType" #30

fix core dump when "new PyType" #30

Conversation

he426100 commented Dec 26, 2023

he426100 commented Dec 26, 2023

matyhtf commented Dec 26, 2023

matyhtf left a comment • edited Loading

Choose a reason for hiding this comment

matyhtf left a comment •

edited

Loading