Skip to content

Commit

Permalink
Remove useless code.
Browse files Browse the repository at this point in the history
  • Loading branch information
@matyhtf
matyhtf committed Aug 21, 2024
1 parent 632f3e8 commit 828b14d
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions config.m4
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,9 @@ if test "$PHP_PHPY" != "no"; then
elif test "$PHP_PYTHON_VERSION" != "no"; then
AC_MSG_RESULT([Python Version: ${PHP_PYTHON_VERSION}])
dnl modern version use python3-embed, old (<= 3.6) use python3
if test "$PHP_PYTHON_VERSION" = "no"; then
PKG_CHECK_MODULES([PYTHON], [python3-embed],,
[PKG_CHECK_MODULES([PYTHON], [python3])]
)
else
PKG_CHECK_MODULES([PYTHON], [python-${PHP_PYTHON_VERSION}-embed],,
[PKG_CHECK_MODULES([PYTHON], [python-${PHP_PYTHON_VERSION}])]
)
fi
PKG_CHECK_MODULES([PYTHON], [python-${PHP_PYTHON_VERSION}-embed],,
[PKG_CHECK_MODULES([PYTHON], [python-${PHP_PYTHON_VERSION}])]
)
PHP_EVAL_LIBLINE($PYTHON_LIBS, PHPY_SHARED_LIBADD)
PHP_EVAL_INCLINE($PYTHON_CFLAGS)
else
Expand Down

1 comment on commit 828b14d

@remicollet
Copy link
Contributor

@remicollet remicollet commented on 828b14d Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, PKG_CHECK_MODULES is not used by default (only when PHP_PYTHON_VERSION is set), IMHO still very ugly.

So I will continue to hack this file for my builds.

Please sign in to comment.