Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclose errors in Handlers #142

Conversation

hiddenalpha
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (1f56133) 77.92% compared to head (07a711d) 77.62%.
Report is 2 commits behind head on develop.

Files Patch % Lines
.../redisques/handler/GetQueuesItemsCountHandler.java 54.54% 5 Missing ⚠️
...swisspush/redisques/handler/DeleteLockHandler.java 66.66% 2 Missing and 1 partial ⚠️
...wisspush/redisques/handler/GetAllLocksHandler.java 80.00% 2 Missing and 1 partial ⚠️
...rg/swisspush/redisques/handler/GetLockHandler.java 72.72% 2 Missing and 1 partial ⚠️
...rg/swisspush/redisques/handler/PutLockHandler.java 66.66% 2 Missing and 1 partial ⚠️
...redisques/handler/RedisquesHttpRequestHandler.java 0.00% 1 Missing and 2 partials ⚠️
...isspush/redisques/handler/AddQueueItemHandler.java 50.00% 1 Missing ⚠️
...isspush/redisques/handler/GetQueueItemHandler.java 50.00% 0 Missing and 1 partial ⚠️
...h/redisques/handler/GetQueueItemsCountHandler.java 50.00% 1 Missing ⚠️
...sspush/redisques/handler/GetQueueItemsHandler.java 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #142      +/-   ##
=============================================
- Coverage      77.92%   77.62%   -0.31%     
- Complexity       717      732      +15     
=============================================
  Files             60       60              
  Lines           2850     2883      +33     
  Branches         269      273       +4     
=============================================
+ Hits            2221     2238      +17     
- Misses           431      444      +13     
- Partials         198      201       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddenalpha hiddenalpha marked this pull request as ready for review December 7, 2023 13:32
@hiddenalpha hiddenalpha merged commit 28fce87 into swisspost:develop Dec 7, 2023
1 of 3 checks passed
@hiddenalpha hiddenalpha deleted the SDCISA-10974-DiscloseErrorsInHandlers-20231207 branch December 7, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant