Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Stencil to v4.25.0 #4509

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore(deps): update Stencil to v4.25.0 #4509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
beb30ba
chore(dependencies): updated Stencil to v4.25.0
alionazherdetska Jan 23, 2025
862a7d2
Merge branch 'main' into 3708-upgrade-to-stencil-4221
alionazherdetska Jan 23, 2025
30fb8fd
chore(updates): updated react-target-output and angular-target-output
alionazherdetska Jan 24, 2025
68a8892
fix(config): update reactOutputTarget for Stencil React integration
alionazherdetska Jan 24, 2025
c76ce06
refactor(events): simplified type for postChange EventEmitter
alionazherdetska Jan 24, 2025
169e98c
Merge branch 'main' into 3708-upgrade-to-stencil-4221
alionazherdetska Jan 24, 2025
acd4098
Merge branch 'main' into 3708-upgrade-to-stencil-4221
alionazherdetska Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
},
"devDependencies": {
"@eslint/js": "9.18.0",
"@stencil/react-output-target": "0.8.2",
"@types/node": "22.10.5",
"@types/react": "18.3.3",
"@types/react-dom": "18.3.5",
Expand Down
1 change: 0 additions & 1 deletion packages/components-react/src/components/index.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions packages/components-react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
'use client';
export * from './components';
export * from './components/stencil-generated/components';
2 changes: 1 addition & 1 deletion packages/components-react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"esModuleInterop": true,
"lib": ["dom", "es2022"],
"module": "esnext",
"moduleResolution": "node",
"moduleResolution": "bundler",
"noImplicitAny": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
Expand Down
6 changes: 3 additions & 3 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
"@percy/cli": "1.30.6",
"@percy/cypress": "3.1.2",
"@stencil-community/eslint-plugin": "0.9.0",
"@stencil/angular-output-target": "0.8.4",
"@stencil/core": "4.19.2",
"@stencil/react-output-target": "0.5.3",
"@stencil/angular-output-target": "0.10.2",
"@stencil/core": "4.25.0",
"@stencil/react-output-target": "0.8.2",
"@stencil/sass": "3.0.12",
"@types/jest": "29.5.14",
"@types/node": "22.10.5",
Expand Down
9 changes: 6 additions & 3 deletions packages/components/stencil.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ export const config: Config = {
},
{
type: 'dist-custom-elements',
externalRuntime: false,
},
{
type: 'dist-custom-elements',
customElementsExportBehavior: 'single-export-module',
dir: 'loaders',
externalRuntime: false,
},
{
type: 'www',
Expand Down Expand Up @@ -54,9 +56,10 @@ export const config: Config = {
file: 'dist/docs.json',
},
reactOutputTarget({
componentCorePackage: '@swisspost/design-system-components',
proxiesFile: '../components-react/src/components/stencil-generated/index.ts',
includeDefineCustomElements: true,
outDir: '../components-react/src/components/stencil-generated',
stencilPackageName: '@swisspost/design-system-components',
// proxiesFile: '../components-react/src/components/stencil-generated/index.ts',
// includeDefineCustomElements: true,
}),
angularOutputTarget({
componentCorePackage: '@swisspost/design-system-components',
Expand Down
4 changes: 2 additions & 2 deletions packages/internet-header/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
"@eslint/js": "9.18.0",
"@percy/cli": "1.30.6",
"@percy/cypress": "3.1.2",
"@stencil-community/eslint-plugin": "0.9.0",
"@stencil/core": "4.19.2",
"@stencil-community/eslint-plugin": "0.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not downgrade @stencil-community/eslint-plugin!

"@stencil/core": "4.25.0",
"@stencil/sass": "3.0.12",
"@stencil/store": "2.0.16",
"@types/body-scroll-lock": "3.1.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/internet-header/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export namespace Components {
* Toggle an overlay associated with a button.
* @param overlayId
*/
"toggleOverlayById": (overlayId: IBreadcrumbOverlay['id']) => Promise<void>;
"toggleOverlayById": (overlayId: IBreadcrumbOverlay["id"]) => Promise<void>;
}
interface SwisspostInternetFooter {
}
Expand Down Expand Up @@ -132,7 +132,7 @@ export namespace Components {
* Get the currently set language as a two letter string ("de", "fr" "it" or "en")
* @returns string
*/
"getCurrentLanguage": () => Promise<'de' | 'fr' | 'it' | 'en' | string>;
"getCurrentLanguage": () => Promise<"de" | "fr" | "it" | "en" | string>;
/**
* Initial language to be used. Overrides automatic language detection.
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/internet-header/src/components/post-internet-breadcrumbs/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

## Methods

### `toggleOverlayById(overlayId: IBreadcrumbOverlay['id']) => Promise<void>`
### `toggleOverlayById(overlayId: IBreadcrumbOverlay["id"]) => Promise<void>`

Toggle an overlay associated with a button.

Expand Down
2 changes: 1 addition & 1 deletion packages/internet-header/src/components/post-internet-header/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

## Methods

### `getCurrentLanguage() => Promise<'de' | 'fr' | 'it' | 'en' | string>`
### `getCurrentLanguage() => Promise<"de" | "fr" | "it" | "en" | string>`

Get the currently set language as a two letter string ("de", "fr" "it" or "en")

Expand Down
Loading
Loading