Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(component): add shadow on optional arrow for post-tooltip component #4441

Merged
merged 7 commits into from
Jan 23, 2025
Merged

chore(component): add shadow on optional arrow for post-tooltip component #4441

merged 7 commits into from
Jan 23, 2025

Conversation

alionazherdetska
Copy link
Contributor

No description provided.

@alionazherdetska alionazherdetska requested a review from a team as a code owner January 14, 2025 21:16
@alionazherdetska alionazherdetska linked an issue Jan 14, 2025 that may be closed by this pull request
[bug]: Tooltips add shadow on optional arrow #4290
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 523045f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alionazherdetska alionazherdetska marked this pull request as draft January 14, 2025 21:16
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jan 14, 2025 •
edited
Loading

Related Previews

@alionazherdetska alionazherdetska changed the title chore[component]: add shadow on optional arrow for post-tooltip component chore(component): add shadow on optional arrow for post-tooltip component Jan 14, 2025
@alionazherdetska alionazherdetska marked this pull request as ready for review January 15, 2025 06:46
gfellerph
gfellerph requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

packages/components/src/components/post-popovercontainer/post-popovercontainer.scss Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alionazherdetska alionazherdetska merged commit d164ad4 into main Jan 23, 2025
10 checks passed
@alionazherdetska alionazherdetska deleted the 4290-bug-tooltips-add-shadow-on-optional-arrow branch January 23, 2025 11:05
alionazherdetska added a commit that referenced this pull request Jan 23, 2025
@alionazherdetska
chore(component): add shadow on optional arrow for post-tooltip com…
daed1a6 
…ponent (#4441)
@alionazherdetska alionazherdetska mentioned this pull request Jan 23, 2025
Merged
@swisspost-bot swisspost-bot mentioned this pull request Jan 24, 2025
Open
alionazherdetska added a commit that referenced this pull request Jan 24, 2025
@alionazherdetska
chore(component): add shadow on optional arrow for post-tooltip com…
9b62038 
…ponent (cherry pick #4441 to v8) (#4506)

…ponent (#4441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Tooltips add shadow on optional arrow
3 participants
@alionazherdetska @swisspost-bot @gfellerph