-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): update mobile menu behaviour #4395
Open
leagrdv
wants to merge
18
commits into
main
Choose a base branch
from
4327-update-megardopdown-mobile-behavior-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8e7850d
update megadropdown styles
leagrdv 653845e
add changeset
leagrdv 4977faa
Merge branch 'main' into 4326-update-megadropdown-styles
leagrdv eb90512
fix mixed-decl warnings
leagrdv d426d10
small fixes on desktop header dropdown
leagrdv 8e664f6
fix(components, documentation): z-index on header + fake content on h…
leagrdv 72b97c6
Revert "fix(components, documentation): z-index on header + fake cont…
leagrdv 36da242
quick fix min height on post list item
leagrdv 0dbb9f8
fixed megadropdown and scrollable content
leagrdv 7b15644
fix pr comments
leagrdv c996717
Merge branch '4326-update-megadropdown-styles' into 4327-update-megar…
leagrdv aae3204
not close megadropdown when click outside on mobile
leagrdv 3cf38fa
stretch mainnavigation to full height on mobile
leagrdv 2f1fe0e
trap focus within dropdowns
leagrdv 56914b6
add changeset
leagrdv e765cd1
Merge branch 'main' into 4327-update-megardopdown-mobile-behavior-2
leagrdv 7ea3433
move device_size to its own file
leagrdv 231fa8b
import from file directly
leagrdv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@swisspost/design-system-components': patch | ||
'@swisspost/design-system-styles': patch | ||
--- | ||
|
||
Fixed display of `post-megadropdown` in header. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only be done if the menu is open, otherwise it's impossible to go back to the logo and skiplinks:
Pressing [shift] + [tab] in this situation locks focus to the menu button.