Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(components): fixed typo in post-accordion-item #4391

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(components): fixed typo in post-accordion-item #4391

wants to merge 4 commits into from

Conversation

schaertim
Copy link
Contributor

No description provided.

@schaertim schaertim linked an issue Jan 7, 2025 that may be closed by this pull request
[bug]: Correct a typo in post-accordion-item component #4381
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9710b25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jan 7, 2025 •
edited
Loading

Related Previews

@schaertim schaertim marked this pull request as ready for review January 7, 2025 12:51
@schaertim schaertim requested a review from a team as a code owner January 7, 2025 12:51
@schaertim schaertim requested a review from leagrdv January 7, 2025 12:51
@schaertim
Copy link
Contributor Author

Not sure if a changeset is needed here...

leagrdv
leagrdv requested changes Jan 7, 2025
View reviewed changes
pnpm-lock.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the lock file change? This shouldn't be in the PR

packages/components/src/components/post-accordion-item/post-accordion-item.tsx Outdated
@@ -81,7 +81,8 @@ export class PostAccordionItem {
}

render() {
const headingLevel = this.host.closest('post-accorddion')?.getAttribute('heading-level');
const headingLevel = this.host.closest('post-accordion')?.getAttribute('heading-level');
console.log(headingLevel);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a console.log

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@schaertim schaertim requested a review from leagrdv January 8, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leagrdv leagrdv Awaiting requested review from leagrdv

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Correct a typo in post-accordion-item component
3 participants
@schaertim @swisspost-bot @leagrdv