fix(focus): fix focus order in post-megadropdown component
#4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 72a583f The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
|
leagrdv
requested changes
Jan 6, 2025
| @@ -88,6 +95,14 @@ export class PostMegadropdown { | |||
| } | |||
| } | |||
|
|
|||
| private getPostListItems(): HTMLElement[] { | |||
There was a problem hiding this comment.
It might be that the first focusable element of the mega dropdown is not the first post-list-item but the post-list title as it could be a link as well.
Comment on lines
+100
to
+102
| const focusableChildren = postListItems.flatMap(el => Array.from(getFocusableChildren(el))); | ||
|
|
||
| return focusableChildren; |
There was a problem hiding this comment.
Suggested change
| const focusableChildren = postListItems.flatMap(el => Array.from(getFocusableChildren(el))); | |
| return focusableChildren; | |
| return postListItems.flatMap(el => Array.from(getFocusableChildren(el))); |
| @@ -98,16 +113,16 @@ export class PostMegadropdown { | |||
| ref={el => (this.popoverRef = el)} | |||
| > | |||
| <div class="megadropdown" onFocusout={e => this.handleFocusout(e)}> | |||
| <slot name="megadropdown-title"></slot> | |||
There was a problem hiding this comment.
This works in desktop but not in mobile, as it puts the back button after the elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.