Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(documentation, styles): text utilities #4360

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Dec 24, 2024

No description provided.

@leagrdv leagrdv linked an issue Dec 24, 2024 that may be closed by this pull request
1 task
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 1e6c5fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 24, 2024

Related Previews

@leagrdv leagrdv marked this pull request as ready for review December 30, 2024 09:19
@leagrdv leagrdv requested review from a team as code owners December 30, 2024 09:19
@leagrdv leagrdv requested a review from alizedebray December 30, 2024 09:19
.changeset/three-geese-run.md Outdated Show resolved Hide resolved
@@ -33,10 +33,6 @@ body {
font-family: tokens.get('body-font-family');
}

.font-sans-serif {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a breaking change. If so, can you create a major changeset?

@@ -28,6 +28,15 @@ $position-values: (
100: 100%,
);

$font-family-sans-serif: var(--post-device-font-family-default);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device layer tokens (post-device-*) are not meant to be used directly, it seems like you are missing a utility token here. You can ask @Vandapanda to create it, it would be nice to have tokens for the font weights and line heights as well. They might be useful for the tailwind output anyways.

Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[utilities ]: text align
3 participants