Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): remove form-control-wrapper classes from stories #3166

Merged
merged 11 commits into from
Jul 11, 2024
Merged

fix(documentation): remove form-control-wrapper classes from stories #3166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cc457b4
fix(documentation): remove form-control-wrapper classes from stories
oliverschuerch Jun 20, 2024
d1f3469
fix(documentation): replace @pxtrn/storybook-addon-docs-stencil with …
oliverschuerch Jun 26, 2024
aa48b12
chore(documentation): remove outdated @storybook/addons package, whic…
oliverschuerch Jun 26, 2024
06bc0e2
Merge branch 'main' into fix/3164-remove-the-form-control-wrapper-fro…
oliverschuerch Jun 26, 2024
6eae026
Merge branch '3180-replace-storybook-addon-docs-stencil-package' into…
oliverschuerch Jun 26, 2024
815c4d6
chore(documentation): remove form-*-wrapper classes out of forms patt…
oliverschuerch Jun 26, 2024
b0aa55b
chore(styles): update focus-ring on validated .form-control and .form…
oliverschuerch Jun 26, 2024
e451787
chore: changeset
oliverschuerch Jun 26, 2024
5f9748e
Merge branch 'main' into fix/3164-remove-the-form-control-wrapper-fro…
oliverschuerch Jun 26, 2024
20b7661
revert(styles): remove form-control validated focus styles
oliverschuerch Jul 10, 2024
cc5e961
Merge branch 'main' into fix/3164-remove-the-form-control-wrapper-fro…
oliverschuerch Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/documentation/src/stories/components/forms/input/input.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,10 @@ function render(args: Args, context: StoryContext) {
`;
if (args.floatingLabel) {
return html`
<div class="form-control-wrapper form-floating">
${[control, label, ...contextual].filter(el => el !== null)}
</div>
<div class="form-floating">${[control, label, ...contextual].filter(el => el !== null)}</div>
`;
} else {
return html`<div class="form-control-wrapper">
${[label, control, ...contextual].filter(el => el !== null)}
</div>`;
return html`${[label, control, ...contextual].filter(el => el !== null)}`;
}
}

Expand Down
6 changes: 2 additions & 4 deletions packages/documentation/src/stories/components/forms/select/select.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,14 +277,12 @@ const Template: Story = {

if (args.floatingLabel) {
return html`
<div class="form-select-wrapper form-floating">
<div class="form-floating">
${[control, label, ...contextuals].filter(el => el !== null)}
</div>
`;
} else {
return html`<div class="form-select-wrapper">
${[label, control, ...contextuals].filter(el => el !== null)}
</div>`;
return html`${[label, control, ...contextuals].filter(el => el !== null)}`;
}
},
};
Expand Down
10 changes: 2 additions & 8 deletions packages/documentation/src/stories/components/forms/slider/slider.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,18 +228,12 @@ function render(args: Args, context: StoryContext) {
if (args.showValue === 'input') {
return html`
<div class="row align-items-end">
<div class="col">
<div class="form-range-wrapper">
${[label, control, ...contextual].filter(el => el !== null)}
</div>
</div>
<div class="col">${[label, control, ...contextual].filter(el => el !== null)}</div>
<div class="col-auto">${valueElement}</div>
</div>
`;
} else {
return html`<div class="form-range-wrapper">
${[label, control, valueElement, ...contextual].filter(el => el !== null)}
</div>`;
return html`${[label, control, valueElement, ...contextual].filter(el => el !== null)}`;
}
}

Expand Down
9 changes: 2 additions & 7 deletions packages/documentation/src/stories/components/forms/textarea/textarea.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,14 +213,9 @@ ${args.textInside ?? nothing}</textarea
`;
if (args.floatingLabel) {
return html`
<div class="form-control-wrapper form-floating">
${[control, label, ...contextual].filter(el => el !== null)}
</div>
<div class="form-floating">${[control, label, ...contextual].filter(el => el !== null)}</div>
`;
} else
return html`<div class="form-control-wrapper">
${[label, control, ...contextual].filter(el => el !== null)}
</div>`;
} else return html`${[label, control, ...contextual].filter(el => el !== null)}`;
}

export const Default: Story = {};
Expand Down
Loading