Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use nanoid everywhere we need random ids? #4209

Closed
3 tasks done
gfellerph opened this issue Dec 11, 2024 · 3 comments · Fixed by #4369
Closed
3 tasks done

Should we use nanoid everywhere we need random ids? #4209

gfellerph opened this issue Dec 11, 2024 · 3 comments · Fixed by #4369
Assignees
Labels
📦 components Related to the @swisspost/design-system-components package 🍀 decision Marks conversations where a decision has been made

Comments

@gfellerph
Copy link
Member

gfellerph commented Dec 11, 2024

Nano id is a tiny library (100 Bytes) https://github.com/ai/nanoid and we'd be able to generate all of these ids in a more readable format than UUID which is safe but quite large. Nanoid is, depending on the length of the string, equally safe from collisions: https://zelark.github.io/nano-id-cc/.

Tasks

Preview Give feedback
@gfellerph gfellerph added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Dec 11, 2024
@alionazherdetska
Copy link
Contributor

alionazherdetska commented Dec 12, 2024

Image

@gfellerph
Copy link
Member Author

Generally yes

@gfellerph gfellerph added 📦 components Related to the @swisspost/design-system-components package and removed needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers labels Dec 12, 2024
@gfellerph gfellerph added this to the Maintenance III milestone Dec 16, 2024
@gfellerph gfellerph added the 🍀 decision Marks conversations where a decision has been made label Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 👀 Triage to 🚀 Done in Design System Production Board Dec 18, 2024
@gfellerph gfellerph reopened this Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 🚀 Done to 👀 Triage in Design System Production Board Dec 18, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 18, 2024
@leagrdv leagrdv self-assigned this Dec 31, 2024
@leagrdv leagrdv linked a pull request Dec 31, 2024 that will close this issue
@leagrdv
Copy link
Contributor

leagrdv commented Dec 31, 2024

outside of the components package, crypto is used a few times in the documentation packages, twice in the internet-header package and once in the icon package.

@leagrdv leagrdv moved this from 💻 Ready for development to 🤬 Dev in Code Review in Design System Production Board Dec 31, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 components Related to the @swisspost/design-system-components package 🍀 decision Marks conversations where a decision has been made
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

3 participants