fix: preview message update script

swisspost · Jan 21, 2025 · 67f55b6 · 67f55b6
1 parent 4ac9108
commit 67f55b6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 23 deletions.
diff --git a/.github/actions/preview/message/update/action.yaml b/.github/actions/preview/message/update/action.yaml
@@ -34,31 +34,32 @@ runs:
           })).data || []
 
           const previewComment = comments.find(c => c.user.login === 'swisspost-bot' && c.body.includes(commentTitle))
+          const iconsUpdateTitle = 'chore(icons): :point_up: update icons'
 
           if (previewComment && !previewComment.body.includes(PREVIEW_URL)) {
-            let updatedBody = previewComment.body
-              .replace(commentInitialBody, '')
-              .concat(`- ${PREVIEW_URL}\n`);
+            let updates = [];
 
-            const issueTitle = await github.rest.issues.get({
+            const issue = await github.rest.issues.get({
               repo: context.repo.repo,
               owner: context.repo.owner,
               issue_number: Number(ISSUE_NUMBER),
-            }).data.title;
+            });
 
-            // If issue is an update icons PR, include an icons health page link 
-            if (issueTitle.includes('chore(icons): :point_up: update icons')) {
-              updatedBody = updatedBody.concat(`- ${PREVIEW_URL}?path=/docs/health-icons--docs\n`)
+            if (issue?.data?.title.includes(iconsUpdateTitle)) {
+              updates.push(`- ${PREVIEW_URL}?path=/docs/health-icons--docs\n`)
             }
 
             await github.rest.issues.updateComment({
               repo: context.repo.repo,
               owner: context.repo.owner,
               comment_id: previewComment.id,
-              body: updatedBody
+              body: previewComment.body
+                .replace(commentInitialBody, '')
+                .concat(`- ${PREVIEW_URL}\n`)
+                .concat(updates.join(''))
             });
 
-            const reactions = (await github.rest.reactions.({
+            const reactions = (await github.rest.reactions.listForIssueComment({
               repo: context.repo.repo,
               owner: context.repo.owner,
               comment_id: previewComment.id,

diff --git a/.github/workflows/build-documentation.yaml b/.github/workflows/build-documentation.yaml
@@ -31,19 +31,6 @@ jobs:
       - name: Install documentation & dependencies
         run: pnpm --filter design-system-documentation... install
 
-      - name: Create preview message
-        uses: ./.github/actions/preview/message/create
-        with:
-          access-token: ${{ secrets.SWISSPOSTDEVS_ACCESS_TOKEN }}
-          issue-number: ${{ github.event.number }}
-
-      - name: Update preview message
-        uses: ./.github/actions/preview/message/update
-        with:
-          access-token: ${{ secrets.SWISSPOSTDEVS_ACCESS_TOKEN }}
-          issue-number: ${{ github.event.number }}
-          preview-url: https://preview-4453--swisspost-design-system-next.netlify.app
-
       - name: Build documentation & dependencies
         run: pnpm --filter design-system-documentation... build