Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: district of a location can be null #4

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Zandv320
Copy link

@Zandv320 Zandv320 commented Oct 22, 2024

Description

Location district can be null.

Motivation and context

The API has changed.

How has this been tested?

I updated the schema and fixtures.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@Zandv320 Zandv320 self-assigned this Oct 22, 2024
@Zandv320 Zandv320 requested a review from JaZo October 22, 2024 12:20
@JaZo JaZo force-pushed the hotfix/location-districts-can-be-null branch from f0dd887 to 283ac74 Compare October 22, 2024 13:42
@JaZo JaZo changed the title fix: Districts of a location can be null, this is now adjusted in the… fix: district of a location can be null Oct 22, 2024
@JaZo JaZo merged commit d44fa3b into master Oct 22, 2024
14 of 15 checks passed
@JaZo JaZo deleted the hotfix/location-districts-can-be-null branch October 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants