Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the fixed amount discount for the coupon type. #11

Open
wants to merge 1 commit into
base: 2.1
Choose a base branch
from

Conversation

aglipanci
Copy link

There are a lot of user that may need this, besides the fact that the admin can create % discount, he can also create fixed amount discount, for example $10 discount coupon.

There are a lot of user that may need this, besides the fact that the admin can create % discount, he can also create fixed amount discount, for example $10 discount coupon.
@stevie-mayhew
Copy link
Member

Hey @aglipanci,

Thanks for this - can you confirm that this works with the multi-currency module? I think that you will need to add an extension point for the Amount() function in the case of a fixed discount.

@aglipanci
Copy link
Author

@stevie-mayhew to be honest i am quite new on SilverStripe, i did this for one of my clients (he doesn't use the multi-currency module actually), however since i remove the fixed amount from the order Amount it should work with any currency (never tried myself).
What do you mean by "extension point for the Amount() function" ?

@stevie-mayhew
Copy link
Member

@aglipanci yes you are correct the amount deducted will be correct in the multi-currency module, however we will need to display the calculated amount per currency to the user on the front end. @frankmullenger any reason why a change like this couldn't go in if it works with multi-currency?

I'll check this out later this week and see if we need to add anything for multi-currency support. I'll let you know how I get on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants