Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-graph 9.0.0 #555

Merged
merged 43 commits into from
Nov 4, 2024
Merged

ngx-graph 9.0.0 #555

merged 43 commits into from
Nov 4, 2024

Conversation

steveblue
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

  1. ngx-graph is compatible with recent versions of Angular, although the package.json requires updating so users can uptake the library without warnings.
  2. There are some inconsistencies with how ngx-graph renders nodes that allow for strange behavior when implementing a clean UX during load, especially when using a loading indicator to wait for when the graph can be displayed.
  3. Documentation Portal was built with JIT and incompatible with recent versions of Angular.
  4. tslint is deprecated
  5. Built on a legacy version of Node.js in CI

What is the new behavior?

  1. Updated and tested against Angular 18
  2. Fixed issues with the way nodes gain dimension, fixed other bugs to allow for cleaner experience on load
  3. Replaced DocSPA with Storybook
  4. Migrated tslint to eslint
  5. Now built with yarn and Node 20

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

The internal changes combined with upgrading Angular from 13 -18 could introduce different behaviors during load, although all previous examples and instances of the ngx-graph used internally work with the changes.

Other information:

@steveblue steveblue merged commit 9944495 into master Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants