Update for Angular 18.x, suppress rfdc #1972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anrideshark in pr swimlane#1763 (with rfdc, there is the same message like clone-deep: CommonJS or AMD dependencies can cause optimization bailouts)
…r/core@15 @angular-eslint/schematics@15 --force package.json: change package for angular to 15.2.9, suppress postinstall
…lls.ts) for angular 15 tsconfig.json: use ES2022 for target/module/lib for angular 15
…ts and karma.conf.js)
…e @angular-eslint/schematics --force
…@typescript-eslint/no-this-alias' for context = this
…e @angular-eslint/schematics --force package.json: change builder to @angular-devkit/build-angular:application package.json: for outputPath, add browser to "" (to have the same structure in dist else add a sub-directory browser)
|
Is this getting merged? |
|
Hello, we also would need that Im near to a POC phase in Angular 18 and I would love to use your lib in there :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
Update package.json for Angular 18.x
Integrate PR Update for Angular 17.x, suppress rfdc #1943 (for Angular 17)
-- Update package.json for angular 17.x
-- Suprress rfdc in boxchart. Package rfdc used in Replace deep clone #1771 generates the message : CommonJS or AMD dependencies can cause optimization bailouts.
My previous code in pr Update tsconfig and package for Angular 13 #1727 has no success. In this pr, code proposed by @bryanrideshark in pr Remove clone-deep dependency #1763 replace cloneDeep in box.component.ts
Fix: Drop dependency on rdfc? CommonJS dependency causes optimisation bailouts. #1901 and 19.1 triggers angular import warning: swimlane-ngx-charts.js depends on 'clone-deep'. CommonJS or AMD dependencies can cause optimization bailouts. #1688
-- Add PR add providedIn: 'root' #1861 to fix Lazy loading NgxChartsModules causes NullInjectorError #1733 (for Angular 17)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Demo for 22.0.0 here:
https://inway.fr/ngx-charts