Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use lock for subsummary to get its values #82

Conversation

blindspotbounty
Copy link
Contributor

There is a race condition listed in #79

Checklist

  • The provided tests still run.
  • [-] I've created new tests where needed.
  • [-] I've updated the documentation if necessary.

Motivation and Context

That solves race-condition and corresponding crash from #79

@blindspotbounty blindspotbounty marked this pull request as draft May 26, 2023 16:12
@blindspotbounty blindspotbounty changed the title fix(patch): [sc-1297] use lock for subsummary to get its values fix: use lock for subsummary to get its values Jul 17, 2023
@blindspotbounty blindspotbounty marked this pull request as ready for review July 17, 2023 12:17
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. This looks correct.

We'd love to make a bigger cleanup here so such mistakes can't happen, but for now let's fix the issue at hand. Thanks!

@ktoso ktoso merged commit 92f87d5 into swift-server:master Jul 18, 2023
@ktoso
Copy link
Collaborator

ktoso commented Jul 18, 2023

Meh, wrong target branch -- we're developing on main, I'll pick it over though 🍒 ⛏️ :)

It seems we had the wrong target branch setting in github -- fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants