Introduce SendableOpaquePointer
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#169 resolves this by adding |
|
Doesn't look like checks are starting. Related to us being mid-migration to GitHub Actions in #175? |
blindspotbounty
approved these changes
Nov 13, 2024
[Unsafe pointers are no longer `Sendable`](swiftlang/swift#70396 (comment)) starting with Swift 5.10, while a warning in earlier versions. This PR introduces `SendableOpaquePointer` to wrap `OpaquePointer` and marks it as `@unchecked Sendable`. Resolves swift-server#159
mimischi
force-pushed
the
issue-159-make-opaquepointer-sendable
branch
from
f84757b to
91155a1
Compare
FranzBusch
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsafe pointers are no longer
Sendablestarting with Swift 5.10, while a warning in earlier versions. This PR introducesSendableOpaquePointerto wrapOpaquePointerand marks it as@unchecked Sendable.Resolves #159