Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

no dependencies #25

Closed
wants to merge 3 commits into from
Closed

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Aug 16, 2017

Hoping to start testing out this package w/ Vapor soon and needed a version that supported Swift 4 and didn't have any dependencies.

I know eventually this package should include an HTTP server built on swift-server/transport, but for now having this package import IBM's ecosystem of packages makes it difficult for us to test.

This probably won't get merged, but I thought i'd contribute it back nonetheless.

  • support Swift 4
  • remove all dependencies
  • include CHTTPParser
  • remove reliance on utils.c

@ianpartridge
Copy link
Contributor

I would support merging the part of this PR which removes the dependency on https://github.com/IBM-Swift/CHTTPParser.git and adds a CHTTPParser target to this package. Or we could create https://github.com/swift-server/CHTTPParser and depend on that.

@seabaylea
Copy link
Member

Hey @tanner0101 . Yes - we should certainly start to remove the dependencies.

In the short term we could do this by bringing everything into the project, i.e. bring in a fork of BlueSocket (stripping it back to just the parts that we're using) etc, and then replace those as TLS and networking comes in.

Would that be reasonable?

Note that @ianpartridge has also raised a PR to add a simple/initial HTTPServer API so users don't have to create a BlueSocketSimpleServer any more.

@tanner0101
Copy link
Member Author

@seabaylea yup. that sounds perfectly reasonable to me!

@carlbrown
Copy link
Contributor

carlbrown commented Aug 31, 2017

Hey @tanner0101 - Please go take a look at #39 and see if you think it resolves this PR's issue to the point that it can be closed.

P.S. I know you mentioned Swift 4 above as well - that's going to happen, and soon (see #40), but that need (as necessary as it is) technically doesn't belong on an issue titled "no dependencies", so I still think this one should be closable.

@seabaylea
Copy link
Member

@tanner0101 I think this work has now been superseded. Are you happy for it to be closed?

@tanner0101 tanner0101 closed this Sep 26, 2017
@tanner0101 tanner0101 deleted the nodeps branch September 26, 2017 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants