Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise timing to all episodes #619

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Add exercise timing to all episodes #619

merged 1 commit into from
Dec 7, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Apr 7, 2024

Fix #519

Total time for the entire lesson is now 4h45min without the supplementary episodes and 8h15min with the supplementary episodes.

Screenshot of the timings table from https://swcarpentry.github.io/r-novice-inflammation/instructor/index.html

Should we reach out on the instructor channel to double check this is in line with the experience of people who have recently taught this lesson?

Fix #519

Co-authored-by: worcjamessmith <[email protected]>
Co-authored-by: Dan Brady <[email protected]>
Copy link

github-actions bot commented Apr 7, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-inflammation/compare/md-outputs..md-outputs-PR-619

The following changes were observed in the rendered markdown documents:

 01-starting-with-data.md   |   2 +-
 02-func-R.md               |   2 +-
 03-loops-R.md              |   2 +-
 04-cond.md                 |   2 +-
 05-cmdline.md              |   2 +-
 06-best-practices-R.md     |   2 +-
 07-knitr-R.md              |   2 +-
 08-making-packages-R.md    |   2 +-
 10-supp-addressing-data.md |   2 +-
 11-supp-read-write-csv.md  |   2 +-
 12-supp-factors.md         |   2 +-
 13-supp-data-structures.md |   2 +-
 14-supp-call-stack.md      |   2 +-
 config.yaml (new)          |  95 +++++++++++++
 md5sum.txt                 |  26 ++--
 renv.lock (new)            | 342 +++++++++++++++++++++++++++++++++++++++++++++
 16 files changed, 463 insertions(+), 26 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-07 09:16:15 +0000

github-actions bot pushed a commit that referenced this pull request Apr 7, 2024
Copy link
Contributor

@isaac-jennings isaac-jennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bisaloo, I agree we should seek experiential feedback from instructors who have taught this recently. Let me know if you would like me to post in The Carpentries #instructors channel for feedback.

@Bisaloo
Copy link
Member Author

Bisaloo commented Apr 11, 2024

Let me know if you would like me to post in The Carpentries #instructors channel for feedback.

Yes, that would be great. Thanks!

@Bisaloo
Copy link
Member Author

Bisaloo commented Nov 30, 2024

Toby Hodges asked for feedback about this issue in #instructors a couple of weeks ago. We didn't get much explicit feedback; only a couple of positive emojis.

In all cases, I believe this PR will be a net positive compared to not having any timings. Once they are present in the lessons, potentially imprecise timings will hopefully trigger more feedback from the community.

I therefore propose we moved forward with merging this PR. Please let me know by the end of next week (December 6th) if you feel strongly against this proposal, otherwise I'll go ahead and merge this at that time.

@Bisaloo Bisaloo merged commit 7f069fe into main Dec 7, 2024
3 checks passed
@Bisaloo Bisaloo deleted the timings branch December 7, 2024 10:34
github-actions bot pushed a commit that referenced this pull request Dec 7, 2024
Auto-generated via `{sandpaper}`
Source  : 7f069fe
Branch  : main
Author  : Hugo Gruson <[email protected]>
Time    : 2024-12-07 10:34:22 +0000
Message : Add exercise timing to all episodes (#619)

Fix #519

Co-authored-by: worcjamessmith <[email protected]>
Co-authored-by: Dan Brady <[email protected]>
github-actions bot pushed a commit that referenced this pull request Dec 7, 2024
Auto-generated via `{sandpaper}`
Source  : 7538cb2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-07 10:35:53 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 7f069fe
Branch  : main
Author  : Hugo Gruson <[email protected]>
Time    : 2024-12-07 10:34:22 +0000
Message : Add exercise timing to all episodes (#619)

Fix #519

Co-authored-by: worcjamessmith <[email protected]>
Co-authored-by: Dan Brady <[email protected]>
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Auto-generated via `{sandpaper}`
Source  : 7f069fe
Branch  : main
Author  : Hugo Gruson <[email protected]>
Time    : 2024-12-07 10:34:22 +0000
Message : Add exercise timing to all episodes (#619)

Fix #519

Co-authored-by: worcjamessmith <[email protected]>
Co-authored-by: Dan Brady <[email protected]>
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Auto-generated via `{sandpaper}`
Source  : 3ce332e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-10 00:32:10 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 7f069fe
Branch  : main
Author  : Hugo Gruson <[email protected]>
Time    : 2024-12-07 10:34:22 +0000
Message : Add exercise timing to all episodes (#619)

Fix #519

Co-authored-by: worcjamessmith <[email protected]>
Co-authored-by: Dan Brady <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercise timing missing for analyzing patient data
2 participants