-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exercise timing to all episodes #619
Conversation
Fix #519 Co-authored-by: worcjamessmith <[email protected]> Co-authored-by: Dan Brady <[email protected]>
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-inflammation/compare/md-outputs..md-outputs-PR-619 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-04-07 09:16:15 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bisaloo, I agree we should seek experiential feedback from instructors who have taught this recently. Let me know if you would like me to post in The Carpentries #instructors channel for feedback.
Yes, that would be great. Thanks! |
Toby Hodges asked for feedback about this issue in #instructors a couple of weeks ago. We didn't get much explicit feedback; only a couple of positive emojis. In all cases, I believe this PR will be a net positive compared to not having any timings. Once they are present in the lessons, potentially imprecise timings will hopefully trigger more feedback from the community. I therefore propose we moved forward with merging this PR. Please let me know by the end of next week (December 6th) if you feel strongly against this proposal, otherwise I'll go ahead and merge this at that time. |
Auto-generated via `{sandpaper}` Source : 7f069fe Branch : main Author : Hugo Gruson <[email protected]> Time : 2024-12-07 10:34:22 +0000 Message : Add exercise timing to all episodes (#619) Fix #519 Co-authored-by: worcjamessmith <[email protected]> Co-authored-by: Dan Brady <[email protected]>
Auto-generated via `{sandpaper}` Source : 7538cb2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-07 10:35:53 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 7f069fe Branch : main Author : Hugo Gruson <[email protected]> Time : 2024-12-07 10:34:22 +0000 Message : Add exercise timing to all episodes (#619) Fix #519 Co-authored-by: worcjamessmith <[email protected]> Co-authored-by: Dan Brady <[email protected]>
Auto-generated via `{sandpaper}` Source : 7f069fe Branch : main Author : Hugo Gruson <[email protected]> Time : 2024-12-07 10:34:22 +0000 Message : Add exercise timing to all episodes (#619) Fix #519 Co-authored-by: worcjamessmith <[email protected]> Co-authored-by: Dan Brady <[email protected]>
Auto-generated via `{sandpaper}` Source : 3ce332e Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-12-10 00:32:10 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 7f069fe Branch : main Author : Hugo Gruson <[email protected]> Time : 2024-12-07 10:34:22 +0000 Message : Add exercise timing to all episodes (#619) Fix #519 Co-authored-by: worcjamessmith <[email protected]> Co-authored-by: Dan Brady <[email protected]>
Fix #519
Total time for the entire lesson is now 4h45min without the supplementary episodes and 8h15min with the supplementary episodes.
Should we reach out on the instructor channel to double check this is in line with the experience of people who have recently taught this lesson?