Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formatjs): Fix missing quotes of plural keys #378

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix(formatjs): Fix missing quotes of plural keys #378

merged 1 commit into from
Dec 24, 2024
+1 −1

Conversation

cuyl
Copy link
Contributor

@cuyl cuyl commented Dec 24, 2024

Closes #377

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: 55ad61e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title fix: missing quotes of plural keys fix(formatjs): Fix missing quotes of plural keys Dec 24, 2024
kdy1
kdy1 reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

kdy1
kdy1 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 merged commit 7a3b1ba into swc-project:main Dec 24, 2024
6 checks passed
@cuyl
Copy link
Contributor Author

cuyl commented Dec 24, 2024

swc-project/swc#9797
@kdy1 You can also close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Output Syntax of Object Key from ICU Plural Argument
2 participants
@cuyl @kdy1