Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emotion): Port label tests and fix label generation #245

Merged
merged 28 commits into from
Jan 18, 2024
Merged

fix(emotion): Port label tests and fix label generation #245

merged 28 commits into from
Jan 18, 2024
+757 −93

Conversation

Codex-
Copy link
Contributor

@Codex- Codex- commented Jan 12, 2024 •
edited
Loading

Apologies for the large PR. This PR addresses a number of issues with label generation when attempting to find a label for [Local].

All behaviour and code generation has been tested between the original babel implementation and this plugin for consistency.

Added

Changed

  • Moved label related tests under a label folder in fixtures.
    • New structure: fixture/labels/*

Fixed

  • Spaces in names now collapsed to singular hyphens.
  • Labels that are unable to find a context emit an empty string instead of [Local]
  • The following fixes have been made to align with the current @emotion/babel-plugin behaviour:
    • Functions on classes now emit their class name as the label.
    • Calls outside of an assignment (i.e. global scoped called to css() do not emit a label.
    • Keys on objects are now used as labels instead of the parent variable assignment. (Fixes @swc/plugin-emotion seemingly not producing correct labels #180)
    • Functions that return calls to css now use the function name as the label. (Fixes @swc/plugin-emotion seemingly not producing correct labels #180)
    • Named function expressions on variable assignments now use the correct label.
    • String keys on objects now generate the expected label.
    • Class methods use the class name for the label. (Upstream behaviour, weirdly).
    • Class members use the member name for the label.
    • Computed properties should not generate a label.

Codex- added 14 commits January 13, 2024 10:47
@Codex-
fix(emotion): Fix local labels not using keys of objects
f62b71f
@Codex-
chore: move label related fixtures into labels sub-dir
8751307
@Codex-
test: port label tests with expected output from the emotion/babel-pl…
72059b3 
…ugin repository
@Codex-
fix: label generation for object prop methods
6456299
@Codex-
fix: label generation for named functions on var assignments
64efe26
@Codex-
fix: label generation for string keys on objects
d98210a
@Codex-
chore: move label tests up one level to prevent test fixture pattern …
39a5bce 
…clash
@Codex-
fix: label generation for functions that return calls to emotion
0ebfab3
@Codex-
fix: label should be empty if no context is available
cd81fb3
@Codex-
test: port more emotion tests
51f3f2e
@Codex-
fix: functions on classes use the class name, but properties use the …
25d9a3c 
…prop name
@Codex-
fix: computed properties should not have a label
a91ac18
@Codex-
test: port remaining emotion tests
9af519b
@Codex-
test: add examples from swc-project#180
7601c2e
@Codex- Codex- mentioned this pull request Jan 12, 2024
Closed
@Codex- Codex- marked this pull request as ready for review January 12, 2024 22:12
kdy1
kdy1 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@kdy1 kdy1 enabled auto-merge (squash) January 18, 2024 09:59
@kdy1 kdy1 disabled auto-merge January 18, 2024 09:59
@kdy1 kdy1 enabled auto-merge (squash) January 18, 2024 09:59
@kdy1 kdy1 merged commit ab782e6 into swc-project:main Jan 18, 2024
6 checks passed
@Codex- Codex- deleted the fix_emotion_label_bugs branch January 18, 2024 11:11
@Codex- Codex- mentioned this pull request Jan 21, 2024
Merged
kdy1 pushed a commit that referenced this pull request Jan 22, 2024
@Codex-
fix(emotion): Fix panic on function name identifier being None (#254)
94d9e63 
Follow up to #245 

Fixes this panic by ensuring that there is something to unwrap:
```
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', /home/runner/work/plugins/plugins/packages/emotion/transform/src/lib.rs:449:48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc-0.270.26/src/plugin.rs:162:14:
failed to invoke plugin: failed to invoke plugin on 'Some("/Users/alexmiller/dev/app/node_modules/jest-runner/build/index.js")'

Caused by:
    0: failed to invoke `@swc/plugin-emotion` as js transform plugin at @swc/plugin-emotion
    1: RuntimeError: unreachable

Stack backtrace:
   0: _napi_register_module_v1
   1: _wasmer_vm_imported_memory32_atomic_notify
   2: _napi_register_module_v1
   3: _napi_register_module_v1
   4: _napi_register_module_v1
   5: _napi_register_module_v1
   6: _napi_register_module_v1
```
@kdy1 kdy1 self-assigned this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@swc/plugin-emotion seemingly not producing correct labels
2 participants
@Codex- @kdy1