Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loadable-components): Transpile lazy and signatures configuration #242

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

Themezv
Copy link
Contributor

@Themezv Themezv commented Dec 18, 2023

closes #241

This pull request brings behavior closer to babel plugin:

  1. Add ability to transpile lazy from @loadable/component without hacks
  2. Add ability to configure signatures. babel plugin doc

BREAKING CHANGE:

Before this changes plugin detected loadable only by loadable keyword.
After you should to configure signatures if you are using imports non from @loadable/component.
For example:

["loadable-components", { "signatures": [
    {
        "from": "myLoadableWrapper",
        "name": "default" 
    },
    {
        "from": "myLoadableWrapper",
        "name": "lazy" 
    }]
}]

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: 4c1e65a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Themezv Themezv changed the title test: Add tests on lazy from loadable-components [DRAFT] Add tests on lazy from loadable-components Apr 30, 2024
@Themezv Themezv marked this pull request as draft April 30, 2024 14:36
@Themezv Themezv force-pushed the loadable-components-lazy-tests branch from b4c3e80 to a325d0a Compare April 30, 2024 23:28
.vscode/settings.json Outdated Show resolved Hide resolved
@Themezv Themezv force-pushed the loadable-components-lazy-tests branch 3 times, most recently from ab11cbf to 041c0d6 Compare May 1, 2024 11:36
@Themezv Themezv changed the title [DRAFT] Add tests on lazy from loadable-components Transpile lazy and signatures configuration May 1, 2024
@Themezv Themezv marked this pull request as ready for review May 1, 2024 11:50
@Themezv Themezv changed the title Transpile lazy and signatures configuration feat(loadable-components)!: Transpile lazy and signatures configuration May 1, 2024
@kdy1 kdy1 self-assigned this May 8, 2024
packages/loadable-components/src/lib.rs Outdated Show resolved Hide resolved
@Themezv Themezv force-pushed the loadable-components-lazy-tests branch from 041c0d6 to bb40b22 Compare June 9, 2024 13:47
@Themezv Themezv requested a review from kdy1 June 9, 2024 14:05
packages/loadable-components/src/lib.rs Outdated Show resolved Hide resolved
@Themezv Themezv force-pushed the loadable-components-lazy-tests branch from bb40b22 to 4c1e65a Compare July 6, 2024 15:16
@Themezv Themezv requested a review from kdy1 July 6, 2024 15:33
@kdy1 kdy1 changed the title feat(loadable-components)!: Transpile lazy and signatures configuration feat(loadable-components): Transpile lazy and signatures configuration Jul 7, 2024
@kdy1 kdy1 merged commit d911134 into swc-project:main Jul 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

loadable-components should transpile lazy too
3 participants