Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emotion): remove multiline comments #229

Merged
merged 24 commits into from
Nov 7, 2023
Merged

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Nov 6, 2023

Remove multiline comments

This is because emotion@10 runtime cannot handle multiline comments properly, the @emotion/babel-plugin removes comments as well.

@JSerFeng JSerFeng marked this pull request as draft November 6, 2023 16:01
@JSerFeng JSerFeng marked this pull request as ready for review November 6, 2023 16:11
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) November 7, 2023 00:31
@kdy1 kdy1 merged commit 02f9822 into swc-project:main Nov 7, 2023
4 checks passed
@kdy1 kdy1 self-assigned this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants