-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add callbacks to cli #56
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests for this?
I tried, I can add tests for |
I think tests to ensure that |
Sure. I will accomplish it later. |
Test cases update. Can you release a beta version for testing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I don't want to delete git tag or publish from a PR branch, I'll merge it first and revert/invert it as needed
add callbacks to cli swc-project/pkgs#56
Closes #55
I rename
packages/cli/src/swc/index.ts
topackages/cli/src/swc/bin.ts
, and exportswcDir
function via newpackages/cli/src/swc/index.ts
add doc here: swc-project/website#261