Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Automessage #319

Closed
wants to merge 22 commits into from
Closed

Update Automessage #319

wants to merge 22 commits into from

Conversation

mansijain980
Copy link
Contributor

Related Issue or bug

Github bot bug

Fixes: #294

Description

Updated the message on closing the issue.

@github-actions github-actions bot requested a review from swapnilsparsh May 18, 2021 15:32
@swapnilsparsh
Copy link
Owner

@mansijain980 Resolve the conflicts.

@mansijain980
Copy link
Contributor Author

image
there is only 1 file "automessage.yml" which is having conflict .

@mansijain980
Copy link
Contributor Author

image

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to change the message, you just have to add the condition if the pr is closed then there should be another message rather than what it is now.

@github-actions github-actions bot requested a review from swapnilsparsh May 24, 2021 17:01
@mansijain980
Copy link
Contributor Author

mansijain980 commented May 25, 2021

image
sir in this code , there is already a condition that when PR is closed it will show " response: This issue is closed @${{ github.event.pull_request.user.login }}. Looking forward for your contributions :) this message .

@swapnilsparsh
Copy link
Owner

image
sir in this code , there is already a condition that when PR is closed it will show " response: This issue is closed @${{ github.event.pull_request.user.login }}. Looking forward for your contributions :) this message .

The message will prompt when PR is merged so you have to make changes when pr is closed.

@mansijain980
Copy link
Contributor Author

mansijain980 commented May 29, 2021

image
@swapnilsparsh we can perform only these actions on workflow nd for the type closed there is already a message . i think we should add a type removed so then when pr will be deleted . there will be some anothwr msg.

@swapnilsparsh
Copy link
Owner

image
@swapnilsparsh we can perform only these actions on workflow nd for the type closed there is already a message . i think we should add a type removed so then when pr will be deleted . there will be some anothwr msg.

Add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Bot Bug
2 participants