Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed navbar and footer for darkmode and lightmode #401

Merged
merged 3 commits into from
Aug 5, 2023
Merged

fixed navbar and footer for darkmode and lightmode #401

merged 3 commits into from
Aug 5, 2023

Conversation

anamika7153
Copy link
Contributor

@anamika7153 anamika7153 commented Jul 25, 2023 •
edited
Loading

Description

Ensured that navbar and footer is compatible for darkmode and light mode

Fixes #393

Screenshots

Light mode:
image image
image image

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for devempire ready!

Name Link
🔨 Latest commit 8d554df
🔍 Latest deploy log https://app.netlify.com/sites/devempire/deploys/64cbf45b6111460007e56a42
😎 Deploy Preview https://deploy-preview-401--devempire.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anamika7153
Copy link
Contributor Author

@swapnilsparsh please review this PR :)

swapnilsparsh
swapnilsparsh requested changes Jul 26, 2023
View reviewed changes
Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navbar ->
image

Footer
image

@anamika7153
Copy link
Contributor Author

anamika7153 commented Jul 26, 2023 •
edited
Loading

Navbar -> image

Footer image

@swapnilsparsh What about navbar??
And I just checked again, footer in light seems okay. In light mode, footer content is of white color with light blue background and in darkmode, content is of blue color with darker blue background. Same with navbar. Shall I attach the working video?

@anamika7153
Copy link
Contributor Author

@swapnilsparsh deploy preview also seems ok

swapnilsparsh
swapnilsparsh requested changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer on production website ->
image

Footer on your preview deployed code
image

@anamika7153
Copy link
Contributor Author

@swapnilsparsh I dont understand where the issue is. Could you please help me out?

swapnilsparsh
swapnilsparsh requested changes Aug 3, 2023
View reviewed changes
Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anamika7153 In mobile view the color of the fonts of dark mode gets changed.

@anamika7153
Copy link
Contributor Author

@anamika7153 In mobile view the color of the fonts of dark mode gets changed.

yeah, thanks for the help.

@anamika7153
Copy link
Contributor Author

@swapnilsparsh I have fixed it, you can check now :) I am also updating screenshots

1 similar comment
@anamika7153
Copy link
Contributor Author

@swapnilsparsh I have fixed it, you can check now :) I am also updating screenshots

@anamika7153
Copy link
Contributor Author

@swapnilsparsh please review

@swapnilsparsh swapnilsparsh merged commit 4ad8a3f into swapnilsparsh:master Aug 5, 2023
@swapnilsparsh swapnilsparsh added gssoc23 GirlScript Summer of Code 2023 level2 Medium labels Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilsparsh swapnilsparsh swapnilsparsh requested changes

Assignees
No one assigned
Labels
gssoc23 GirlScript Summer of Code 2023 level2 Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar and footer for darkmode
2 participants
@anamika7153 @swapnilsparsh