Skip to content

Commit

Permalink
feat(ict): remove quote in amount summary (#500)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nicolas Comont authored Dec 14, 2023
1 parent d67f24f commit 65d62c1
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 59 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ const styles = StyleSheet.create({
export type Amount = {
value: string;
currency: Currency;
metadata?: { rate: string; total: Amount; out: Amount };
};

const FIXED_AMOUNT_DEFAULT_VALUE = "";
Expand Down Expand Up @@ -264,7 +263,6 @@ export const TransferInternationalWizardAmount = ({
onSave({
value: values.amount.value,
currency: values.amount.currency as Currency,
metadata,
});
}
})
Expand Down Expand Up @@ -304,39 +302,6 @@ export const TransferInternationamWizardAmountSummary = ({
<LakeHeading level={4} variant="h4">
{formatCurrency(Number(amount.value), amount.currency)}
</LakeHeading>

{isNotNullish(amount.metadata) && (
<>
<Space height={16} />

<LakeText color={colors.gray[700]} variant="smallRegular">
{formatNestedMessage("transfer.new.internationalTransfer.amount.summary.rate", {
rate: amount.metadata.rate,
black: str => <LakeText color={colors.gray[900]}>{str}</LakeText>,
})}
</LakeText>

<LakeText color={colors.gray[700]} variant="smallRegular">
{formatNestedMessage("transfer.new.internationalTransfer.amount.summary.total", {
total: formatCurrency(
Number(amount.metadata.total.value),
amount.metadata.total.currency,
),
black: str => <LakeText color={colors.gray[900]}>{str}</LakeText>,
})}
</LakeText>

<LakeText color={colors.gray[700]} variant="smallRegular">
{formatNestedMessage("transfer.new.internationalTransfer.amount.summary.out", {
out: formatCurrency(
Number(amount.metadata.out.value),
amount.metadata.out.currency,
),
black: str => <LakeText color={colors.gray[900]}>{str}</LakeText>,
})}
</LakeText>
</>
)}
</View>

<Fill />
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Sie senden genau <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Gesamtbetrag, den wir in <bold>{amount}</bold> umrechnen (Wechselkurs {rate})",
"transfer.new.internationalTransfer.amount.label": "Empfänger erhält",
"transfer.new.internationalTransfer.amount.summary.out": "Sie senden genau (Gesamtsumme zum Umrechnen + Gebühr): <black>{out}</black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Wechselkurs (für 1 Geschäftstag gesperrt): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "Gesamtsumme zum Umrechnen: <black>{total}</black>",
"transfer.new.internationalTransfer.amount.title": "Geben Sie Details zu Ihrer Überweisung ein",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "Der Wert entspricht nicht dem erwarteten Muster",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "Der Wert entspricht nicht dem erwarteten Muster (Beispiel: {example})",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -742,9 +742,6 @@
"transfer.new.internationalTransfer.errors.title": "Some error occured",
"transfer.new.internationalTransfer.fee": "Transfer fee <bold>{fee}</bold>",
"transfer.new.internationalTransfer.amount.converted": "You send exactly <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.summary.rate": "Exchange rate (locked for 1 business day): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "The total amount to convert: <black>{total}</black>",
"transfer.new.internationalTransfer.amount.summary.out": "You send exactly (total amount to convert+fee): <black>{out}</black>",
"transfer.new.internationalTransfer.beneficiary.title": "Who are you sending money to?",
"transfer.new.internationalTransfer.beneficiary.name": "Beneficiary name",
"transfer.new.internationalTransfer.beneficiary.form.field.unknown": "Field type not implemented",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Estás enviando exactamente <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Cantidad total que convertiremos <bold>{amount}</bold> (Tipo de cambio {rate})",
"transfer.new.internationalTransfer.amount.label": "El beneficiario recibe",
"transfer.new.internationalTransfer.amount.summary.out": "Envías exactamente (cantidad total a convertir + comisión): <black>{out}</black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Tipo de cambio (bloqueado por 1 día hábil): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "Cantidad total a convertir: <black>{total}</black>",
"transfer.new.internationalTransfer.amount.title": "Introduce los detalles de tu transferencia",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "El valor no coincide con el formato esperado",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "El valor no coincide con el formato esperado (ejemplo: {example})",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Siirrät tarkalleen <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Vaihdamme summan <bold>{amount}</bold> (vaihtokurssi{rate})",
"transfer.new.internationalTransfer.amount.label": "Vastaanottaja saa",
"transfer.new.internationalTransfer.amount.summary.out": "Lähetät täsmälleen (muunnettava kokonaissumma+maksu): <black> {out} </black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Valuuttakurssi (lukittu 1 työpäiväksi): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "Muunnettava kokonaismäärä: <black> {total} </black>",
"transfer.new.internationalTransfer.amount.title": "Anna tietoja siirrosta",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "Arvo ei vastaa odotettua kuviota",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "Arvo ei vastaa odotettua kuviota (example: {example})",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Vous envoyez exactement <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Montant total que nous convertirons <bold>{amount}</bold> (Taux de change {rate})",
"transfer.new.internationalTransfer.amount.label": "Le bénéficiaire reçoit",
"transfer.new.internationalTransfer.amount.summary.out": "Vous envoyez exactement (montant total à convertir + frais) : <black>{out}</black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Taux de change (verrouillé pendant 1 jour ouvré) : <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "Montant total à convertir : <black>{total}</black>",
"transfer.new.internationalTransfer.amount.title": "Entrez les détails de votre virement",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "La valeur ne correspond pas au format attendu",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "La valeur ne correspond pas au format attendu (exemple : {example})",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Invii esattamente <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Importo totale che convertiremo <bold>{amount}</bold> (Tasso di cambio {rate})",
"transfer.new.internationalTransfer.amount.label": "Beneficiario riceve",
"transfer.new.internationalTransfer.amount.summary.out": "Invii esattamente (importo totale da convertire + commissione): <black>{out}</black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Tasso di cambio (bloccato per 1 giorno lavorativo): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "Importo totale da convertire: <black>{total}</black>",
"transfer.new.internationalTransfer.amount.title": "Inserisci i dettagli del tuo bonifico",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "Il valore non corrisponde al pattern atteso",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "Il valore non corrisponde al pattern atteso (esempio: {example})",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Je stuurt precies <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Totaalbedrag dat we omrekenen: <bold>{amount}</bold> (Wisselkoers: {rate})",
"transfer.new.internationalTransfer.amount.label": "Begunstigde ontvangt",
"transfer.new.internationalTransfer.amount.summary.out": "Je stuurt precies (totale bedrag om te converteren + vergoeding): <black>{out}</black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Wisselkoers (1 werkdag vastgezet): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "Het totale bedrag om te converteren: <black>{total}</black>",
"transfer.new.internationalTransfer.amount.title": "Geef details over je overschrijving",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "De waarde komt niet overeen met het verwachte patroon",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "De waarde komt niet overeen met het verwachte patroon (bijvoorbeeld: {example})",
Expand Down
3 changes: 0 additions & 3 deletions clients/banking/src/locales/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,6 @@
"transfer.new.internationalTransfer.amount.converted": "Você envia exatamente <colored>{amount}</colored>",
"transfer.new.internationalTransfer.amount.description": "Valor total a ser convertido <bold>{amount}</bold> (Taxa de câmbio {rate})",
"transfer.new.internationalTransfer.amount.label": "Beneficiário recebe",
"transfer.new.internationalTransfer.amount.summary.out": "Você envia exatamente (valor total a ser convertido + taxa): <black>{out}</black>",
"transfer.new.internationalTransfer.amount.summary.rate": "Taxa de câmbio (bloqueada por 1 dia útil): <black>{rate}</black>",
"transfer.new.internationalTransfer.amount.summary.total": "O valor total a ser convertido: <black>{total}</black>",
"transfer.new.internationalTransfer.amount.title": "Insira os detalhes sobre a sua transferência",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid": "O valor não corresponde ao padrão esperado",
"transfer.new.internationalTransfer.beneficiary.form.field.invalid.example": "O valor não corresponde ao padrão esperado (exemplo: {example})",
Expand Down

0 comments on commit 65d62c1

Please sign in to comment.