Enable noDoubleEquals

swan-io · Jan 10, 2025 · 343c239 · 343c239
1 parent 7d8c081
commit 343c239
Show file tree

Hide file tree

Showing 17 changed files with 25 additions and 26 deletions.
diff --git a/biome.json b/biome.json
@@ -63,7 +63,6 @@
         "noConfusingVoidType": "off",
         "noShadowRestrictedNames": "off",
 
-        "noDoubleEquals": "off",
         "noGlobalIsNan": "off"
       }
     }

diff --git a/clients/banking/src/components/CardWizard.tsx b/clients/banking/src/components/CardWizard.tsx
@@ -282,7 +282,7 @@ export const CardWizard = ({
 
     const card = input.cards[0];
 
-    if (input.cards.length === 1 && card != undefined) {
+    if (input.cards.length === 1 && card != null) {
       return addSingleUseCard({
         input: {
           name: card.name,

diff --git a/clients/banking/src/components/CardWizardDelivery.tsx b/clients/banking/src/components/CardWizardDelivery.tsx
@@ -60,7 +60,7 @@ export const CardWizardDelivery = forwardRef<CardWizardDeliveryRef, Props>(
               <Box alignItems="center">
                 <Icon
                   color={
-                    currentDeliveryMode == cardDeliveryMode ? colors.swan[300] : colors.swan[200]
+                    currentDeliveryMode === cardDeliveryMode ? colors.swan[300] : colors.swan[200]
                   }
                   size={148}
                   name={match(cardDeliveryMode)

diff --git a/clients/banking/src/components/CardWizardSettings.tsx b/clients/banking/src/components/CardWizardSettings.tsx
@@ -558,7 +558,7 @@ export const CardWizardSettings = forwardRef<CardWizardSettingsRef, Props>(
                       <Box alignItems="center">
                         <Icon
                           color={
-                            currentSettings.spendingLimit.period == period
+                            currentSettings.spendingLimit.period === period
                               ? colors.swan[300]
                               : colors.swan[200]
                           }

diff --git a/clients/banking/src/components/ErrorView.tsx b/clients/banking/src/components/ErrorView.tsx
@@ -24,7 +24,7 @@ type Props = {
 
 export const ErrorView = ({ error, style }: Props) => {
   const [requestId] = useState<Option<string>>(() => {
-    if (error == undefined) {
+    if (error == null) {
       return Option.None();
     }
     return Array.findMap(ClientError.toArray(error), error =>

diff --git a/clients/banking/src/components/MerchantProfileEditor.tsx b/clients/banking/src/components/MerchantProfileEditor.tsx
@@ -142,7 +142,7 @@ export const MerchantProfileEditor = forwardRef<MerchantProfileEditorRef, Props>
                   accentColor,
                 }) => {
                   const base64Logo =
-                    merchantLogoUrl == undefined
+                    merchantLogoUrl == null
                       ? Future.value(Option.None<string>())
                       : Future.make<Option<string>>(resolve => {
                           const reader = new FileReader();

diff --git a/clients/banking/src/components/TransferBulkUpload.tsx b/clients/banking/src/components/TransferBulkUpload.tsx
@@ -65,7 +65,7 @@ const parseCsv = (text: string): Result<CreditTransferInput[], ParsingError[]> =
               }
               if (
                 reference != null &&
-                reference.trim() != "" &&
+                reference.trim() !== "" &&
                 validateTransferReference(reference.trim()) != null
               ) {
                 return Result.Error({ type: "InvalidReference", line: index + 1 } as const);

diff --git a/clients/banking/src/utils/projectId.ts b/clients/banking/src/utils/projectId.ts
@@ -1,7 +1,7 @@
 import { Option, Result } from "@swan-io/boxed";
 
 export const projectConfiguration = Result.fromExecution(() => {
-  if (typeof __env.SWAN_PROJECT_ID == "string") {
+  if (typeof __env.SWAN_PROJECT_ID === "string") {
     return __env.SWAN_PROJECT_ID;
   } else {
     throw new Error();

diff --git a/clients/onboarding/src/components/ErrorView.tsx b/clients/onboarding/src/components/ErrorView.tsx
@@ -24,7 +24,7 @@ type Props = {
 
 export const ErrorView = ({ error, style }: Props) => {
   const [requestId] = useState<Option<string>>(() => {
-    if (error == undefined) {
+    if (error == null) {
       return Option.None();
     }
     return Array.findMap(ClientError.toArray(error), error =>

diff --git a/clients/onboarding/src/utils/projectId.ts b/clients/onboarding/src/utils/projectId.ts
@@ -1,7 +1,7 @@
 import { Option, Result } from "@swan-io/boxed";
 
 export const projectConfiguration = Result.fromExecution(() => {
-  if (typeof __env.SWAN_PROJECT_ID == "string") {
+  if (typeof __env.SWAN_PROJECT_ID === "string") {
     return __env.SWAN_PROJECT_ID;
   } else {
     throw new Error();

diff --git a/clients/onboarding/src/utils/validation.ts b/clients/onboarding/src/utils/validation.ts
@@ -12,7 +12,7 @@ import {
 import { locale, t } from "./i18n";
 
 export const validateRequiredBoolean: Validator<boolean | undefined> = value => {
-  if (typeof value != "boolean") {
+  if (typeof value !== "boolean") {
     return t("error.requiredField");
   }
 };

diff --git a/clients/payment/src/components/ErrorView.tsx b/clients/payment/src/components/ErrorView.tsx
@@ -24,7 +24,7 @@ type Props = {
 
 export const ErrorView = ({ error, style }: Props) => {
   const [requestId] = useState<Option<string>>(() => {
-    if (error == undefined) {
+    if (error == null) {
       return Option.None();
     }
     return Array.findMap(ClientError.toArray(error), error =>

diff --git a/clients/payment/src/utils/projectId.ts b/clients/payment/src/utils/projectId.ts
@@ -1,7 +1,7 @@
 import { Option, Result } from "@swan-io/boxed";
 
 export const projectConfiguration = Result.fromExecution(() => {
-  if (typeof __env.SWAN_PROJECT_ID == "string") {
+  if (typeof __env.SWAN_PROJECT_ID === "string") {
     return __env.SWAN_PROJECT_ID;
   } else {
     throw new Error();

diff --git a/server/src/api/oauth2.swan.ts b/server/src/api/oauth2.swan.ts
@@ -39,7 +39,7 @@ export const exchangeToken = (originalAccessToken: string, config: ExchangeToken
     ),
     headers: {
       "Content-Type": "application/json",
-      ...(additionalEnv.SWAN_AUTH_TOKEN != undefined
+      ...(additionalEnv.SWAN_AUTH_TOKEN != null
         ? { "x-swan-frontend": additionalEnv.SWAN_AUTH_TOKEN }
         : undefined),
     },

diff --git a/server/src/api/partner.ts b/server/src/api/partner.ts
@@ -21,7 +21,7 @@ let projectId: Future<
 >;
 
 export const getProjectId = () => {
-  if (projectId != undefined) {
+  if (projectId != null) {
     return projectId;
   }
   projectId = getClientAccessToken()

diff --git a/server/src/app.ts b/server/src/app.ts
@@ -248,7 +248,7 @@ export const start = async ({
       const refreshToken = request.session.get("refreshToken");
       const expiresAt = request.session.get("expiresAt") ?? 0;
 
-      if (typeof refreshToken == "string" && expiresAt < Date.now() + TEN_SECONDS) {
+      if (typeof refreshToken === "string" && expiresAt < Date.now() + TEN_SECONDS) {
         refreshAccessToken({
           refreshToken,
           redirectUri: `${env.BANKING_URL}/auth/callback`,
@@ -349,7 +349,7 @@ export const start = async ({
     return reply.from(env.PARTNER_API_URL, {
       rewriteRequestHeaders: (_req, headers) => ({
         ...headers,
-        ...(request.accessToken != undefined
+        ...(request.accessToken != null
           ? { Authorization: `Bearer ${request.accessToken}` }
           : undefined),
       }),
@@ -363,7 +363,7 @@ export const start = async ({
     return reply.from(env.PARTNER_ADMIN_API_URL, {
       rewriteRequestHeaders: (_req, headers) => ({
         ...headers,
-        ...(request.accessToken != undefined
+        ...(request.accessToken != null
           ? { Authorization: `Bearer ${request.accessToken}` }
           : undefined),
       }),
@@ -561,7 +561,7 @@ export const start = async ({
 
     return reply.redirect(
       createAuthUrl({
-        scope: scope.split(" ").filter(item => item != null && item != ""),
+        scope: scope.split(" ").filter(item => item != null && item !== ""),
         params: {
           ...(email != null ? { email } : null),
           ...(onboardingId != null ? { onboardingId } : null),
@@ -639,7 +639,7 @@ export const start = async ({
                           Ok: ({ redirectUrl, state, accountMembershipId, oAuthClientId }) => {
                             const queryString = new URLSearchParams();
 
-                            if (redirectUrl != undefined) {
+                            if (redirectUrl != null) {
                               const redirectHost = new URL(redirectUrl).hostname;
 
                               // When onboarding from the dashboard, we don't yet have a OAuth2 client,
@@ -659,7 +659,7 @@ export const start = async ({
                               }
                             }
 
-                            if (accountMembershipId != undefined) {
+                            if (accountMembershipId != null) {
                               queryString.append("accountMembershipId", accountMembershipId);
                             }
 
@@ -689,7 +689,7 @@ export const start = async ({
                           Ok: ({ redirectUrl, state, accountMembershipId }) => {
                             const queryString = new URLSearchParams();
 
-                            if (redirectUrl != undefined) {
+                            if (redirectUrl != null) {
                               const authUri = createAuthUrl({
                                 scope: [],
                                 redirectUri: redirectUrl,
@@ -700,7 +700,7 @@ export const start = async ({
                               queryString.append("redirectUrl", authUri);
                             }
 
-                            if (accountMembershipId != undefined) {
+                            if (accountMembershipId != null) {
                               queryString.append("accountMembershipId", accountMembershipId);
                             }
 

diff --git a/server/src/index.swan.ts b/server/src/index.swan.ts
@@ -199,7 +199,7 @@ start({
     app.post<{ Params: { projectId: string } }>(
       "/api/projects/:projectId/partner",
       async (request, reply) => {
-        if (request.accessToken == undefined) {
+        if (request.accessToken == null) {
           return reply.status(401).send("Unauthorized");
         }
         const projectUserToken = await exchangeToken(request.accessToken, {
@@ -224,7 +224,7 @@ start({
     app.post<{ Params: { projectId: string } }>(
       "/api/projects/:projectId/partner-admin",
       async (request, reply) => {
-        if (request.accessToken == undefined) {
+        if (request.accessToken == null) {
           return reply.status(401).send("Unauthorized");
         }
         const projectUserToken = await exchangeToken(request.accessToken, {
@@ -261,7 +261,7 @@ start({
         if (inviterAccountMembershipId == null) {
           return reply.status(400).send("Missing inviterAccountMembershipId");
         }
-        if (request.accessToken == undefined) {
+        if (request.accessToken == null) {
           return reply.status(401).send("Unauthorized");
         }
         try {