Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resources to use another partition than Common #33

Merged
merged 2 commits into from
May 21, 2019
Merged

Allow resources to use another partition than Common #33

merged 2 commits into from
May 21, 2019

Conversation

Tensibai
Copy link
Contributor

@Tensibai Tensibai commented Feb 26, 2019 •
edited
Loading

  • Add delivery cookbook to be able to run delivery local verify to lint and test
  • Add partition handling to all resources
  • Fix tests to allow the extra message of System.Session
  • Add a test for partition
  • Anchor of regexes

Fix issues #3 as well

@Tensibai Tensibai mentioned this pull request Feb 26, 2019
Closed
@Tensibai @bastien-jove-cbp
Add generated delivery configuration
fa65c2f 
Allow to specify partitions in resources.

Fix tests to handle the partition change, add a test for partition.

Anchor regexes to avoid matching a pool contained by another (pool-web vs pool-webservers for exemple)

Strip slashes from partition to ensure coherence, fix the irule existence test
@Tensibai Tensibai force-pushed the Fix_tests_and_style branch from 693cbda to fa65c2f Compare May 21, 2019 09:06
@Tensibai Tensibai changed the title Fix tests and style Allow resources to use another partition than Common May 21, 2019
@Tensibai Tensibai force-pushed the Fix_tests_and_style branch from 2acc435 to 0014ceb Compare May 21, 2019 09:43
@swalberg
Copy link
Owner

Thanks! I see it's passing the checks now, I will look through this.

@swalberg
Copy link
Owner

Thanks a bunch, I'll merge this in and release shortly.

@swalberg swalberg merged commit e182f47 into swalberg:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalberg swalberg swalberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tensibai @swalberg