add support for retry configurations #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjorri
force-pushed
the
feature/hydra-api-retry
branch
from
d17b288 to
2859a2a
Compare
svrakitin
approved these changes
May 28, 2024
svrakitin
reviewed
May 28, 2024
svrakitin
reviewed
May 28, 2024
|
LGTM, thanks, just couple of nitpicks on better naming. |
|
@tjorri Please regenerate docs and I'll merge. |
|
Thanks, good comments, and yeah, totally forgot about the docs. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issues we reported in #19 by introducing a configurable backoff-retry wrapper which jitter for Hydra SDK calls to more gracefully handle the rate-limiting.
By default the retry is disabled and needs to be explicitly enabled to maintain existing provider behavior and not surprise anyone.
The implementation might be a bit rough around the edges, and mainly tried to quickly get the issues we are facing sorted, so happy to refactor as needed if other better approaches are thought of. :)