Add support for setting an access token strategy (and update to latest SDKs) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svanharmelen Thanks for your work! I'll check now. |
|
Thanks 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to be able to set the access token strategy, but as that is only supported in newer versions of the SDK I needed to update (everything) first 😅
I did notice that you mentioned you needed/wanted to do update stuff back in April, so I assumed this is something that you wanted anyway?
If not we can of course release a version of this provider ourselves, but I very much prefer to keep using this version instead. So please let me know your thoughts as of course I understand it's not a small change and it means a new version of this provider will drop support for Hydra
v1.x(as there is at least one backwards incompatible change in thev2SDK).