Keep C# enum value sequence

[digocesar]

As I could test, TypeScript folow the same C# numbering sequence when enum value is missing in declaring type.
I think that if no number is defined in C#, it could remains not defined in TypeScript.
@svenheden and @SafeerH, any idea of problems we might have with this change?

C#: https://sharplab.io/#v2:CYLg1APgAgzABAUwHYFcC2cBCBLANr7JAcwGEBPAY1wQFgAoAb3rhYEEAaZlzOAXjgDsnOizglhogCJ84AFgksAovQC+QA==
TypeScript: https://www.typescriptlang.org/play/?#code/KYOwrgtgBAQglgGwXEBzAwgTwMYOAKAG98pSBBAGhNJigF4oB2K0qdF0gEXqgBYOoAUXwBfIA

Closes #29

[svenheden]

value is always != null here, so this ternary expression can be removed

[digocesar]

Thats right! My mistake!
I did an ammend for previous commit.

[svenheden]

As I could test, TypeScript folow the same C# numbering sequence when enum value is missing in declaring type.
I think that if no number is defined in C#, it could remains not defined in TypeScript.
@svenheden and @SafeerH, any idea of problems we might have with this change?

No to my ears that sounds solid, go for it 👍

[SafeerH]

As I could test, TypeScript folow the same C# numbering sequence when enum value is missing in declaring type. I think that if no number is defined in C#, it could remains not defined in TypeScript. @svenheden and @SafeerH, any idea of problems we might have with this change?

C#: https://sharplab.io/#v2:CYLg1APgAgzABAUwHYFcC2cBCBLANr7JAcwGEBPAY1wQFgAoAb3rhYEEAaZlzOAXjgDsnOizglhogCJ84AFgksAovQC+QA== TypeScript: https://www.typescriptlang.org/play/?#code/KYOwrgtgBAQglgGwXEBzAwgTwMYOAKAG98pSBBAGhNJigF4oB2K0qdF0gEXqgBYOoAUXwBfIA

Closes #29

Sounds good to me! 👍

[SafeerH]

@digocesar could you add G value to the TestEnum in TestClass.cs just for the completeness?

public enum TestEnum {
    ...
    G    // 27 in decimal
}

Also, some suggestions to consider:

• Change the TestClass.cs file name to TestFile.cs (because we now have enum as well)
• Change the namespace to TestNamespace (instead of TestClass)

[digocesar]

@digocesar could you add G value to the TestEnum in TestClass.cs just for the completeness?

public enum TestEnum {
    ...
    G    // 27 in decimal
}

Also, some suggestions to consider:

• Change the TestClass.cs file name to TestFile.cs (because we now have enum as well)
• Change the namespace to TestNamespace (instead of TestClass)

Done.

[SafeerH]

Hey guys @svenheden @digocesar, I think it is a high time we publish a new NPM release. Also, what do you guys think about bumping up the major version - because we migrated to .NET 8 and we have a lot of other good improvements as well?

[digocesar]

Hey guys @svenheden @digocesar, I think it is a high time we publish a new NPM release. Also, what do you guys think about bumping up the major version - because we migrated to .NET 8 and we have a lot of other good improvements as well?

I was thinking to suggest it too.
I think we should release a version so that the component works again and then we will make other improvements.

[svenheden]

Sounds good guys! I just bumped the version to 1.0.0 and published to npm.

@SafeerH @digocesar