Skip to content

Commit

Permalink
Implement SortOptionsVariant in FieldSort (opensearch-project#1323)
Browse files Browse the repository at this point in the history
* Implement SortOptionsVariant in FieldSort

Signed-off-by: Kosuke Suzuki <[email protected]>

* Add change log

Signed-off-by: Kosuke Suzuki <[email protected]>

---------

Signed-off-by: Kosuke Suzuki <[email protected]>
(cherry picked from commit f9540f7)
  • Loading branch information
suzuki764 committed Nov 25, 2024
1 parent 008c013 commit 0e30e26
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Fixed
- Fixed `IcuCollationDecomposition`'s variants to align with those supported by OpenSearch ([#]())
- Fixed don't invoke the mapper's serialize method for the RangeQuery JsonData raw value [#1309](https://github.com/opensearch-project/opensearch-java/pull/1309)
- Fixed an issue where `FieldSort` was not implementing `SortOptionsVariant` ([#1323](https://github.com/opensearch-project/opensearch-java/pull/1323))

### Security

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
// typedef: _types.FieldSort

@JsonpDeserializable
public class FieldSort implements PlainJsonSerializable {
public class FieldSort implements SortOptionsVariant, PlainJsonSerializable {
// Single key dictionary
private final String field;

Expand Down Expand Up @@ -94,6 +94,14 @@ public static FieldSort of(Function<Builder, ObjectBuilder<FieldSort>> fn) {
return fn.apply(new Builder()).build();
}

/**
* SortOptions variant kind.
*/
@Override
public SortOptions.Kind _sortOptionsKind() {
return SortOptions.Kind.Field;
}

/**
* Required - The target field
*/
Expand Down

0 comments on commit 0e30e26

Please sign in to comment.