Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

[WIP] feat: support Views API #183

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

suzuki-shunsuke
Copy link
Owner

issue: #182

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #183 into master will decrease coverage by 0.42%.
The diff coverage is 43.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   52.96%   52.54%   -0.43%     
==========================================
  Files         126      130       +4     
  Lines        6062     6336     +274     
==========================================
+ Hits         3211     3329     +118     
- Misses       2657     2813     +156     
  Partials      194      194              
Impacted Files Coverage Δ
graylog/client/endpoint/view.go 0.00% <0.00%> (ø)
graylog/graylog/view.go 0.00% <0.00%> (ø)
graylog/client/view.go 16.12% <16.12%> (ø)
graylog/terraform/resource_view.go 63.42% <63.42%> (ø)
graylog/client/endpoint/endpoint.go 82.35% <100.00%> (+0.35%) ⬆️
graylog/terraform/provider.go 97.29% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26bd26...b5da60b. Read the comment docs.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Oct 3, 2019
@suzuki-shunsuke
Copy link
Owner Author

suzuki-shunsuke commented Apr 17, 2020

hashicorp/terraform-plugin-sdk#62

Oh, we have to fix state.

https://pkg.go.dev/github.com/hashicorp/terraform/helper/schema?tab=doc#Schema

For a TypeMap, it must be a *Schema with a Type that is one of the primitives: TypeString, TypeBool, TypeInt, or TypeFloat

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant