Remove bulk insert and allow inserting equal versions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriqaaq
reviewed
Oct 2, 2024
arriqaaq
reviewed
Oct 2, 2024
gsserge
force-pushed
the
remove_bulk_insert
branch
from
06f1ee2
to
bed9737
Compare
arriqaaq
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax little bit the versioned guarantees of
Tree::insertby allowing values with the versions equal to the root. This allows us to removeTree::bulk_insert, because now the normalTree::insertcan be used in the most common path in SurrealKV when writing committed entries.Tested with SurrealKV and SurrealDB.