Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting in flatnode #26

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: sorting in flatnode #26

merged 1 commit into from
Apr 24, 2024

Conversation

arriqaaq
Copy link
Contributor

Description

Insertion into the Flatnode were falsely sorting the key in reverse order. This lead to unsorted keys in flatnodes

@arriqaaq arriqaaq mentioned this pull request Apr 24, 2024
@arriqaaq arriqaaq changed the title fix: remove reverse sorting in flatnode when finding insert slot fix: sorting in flatnode Apr 24, 2024
Copy link

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arriqaaq arriqaaq merged commit 88577bd into main Apr 24, 2024
1 check passed
@arriqaaq arriqaaq deleted the fix/node4-sorting-error branch April 24, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants