chore: remove snapshot counters #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriqaaq
force-pushed
the
chore/remove-snapshot-counters
branch
from
fcdd0b9
to
2eba6cd
Compare
arriqaaq
force-pushed
the
chore/remove-snapshot-counters
branch
from
2eba6cd
to
c1e189b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea to keep track of active snapshots was to control the number of snapshots spawned in case we write snapshots to file. There is no need to keep track of snapshots currently as it provides no real benefit, and there are no writes to disk for vart right now.