Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency pinning #42

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

stevenbunting
Copy link
Collaborator

Still figuring out the best practices for dependencies in a client library. I'm used to pinning dependencies in an app to the minimum viable set, but in a library you want to be more careful about allowing for more permissibility.

At some point it'd be nice to do a full audit, but realistically we'll probably just expand permissions when the need arises like we're currently doing. I'll develop some test scripts to make expansions like this less manual.

Addresses Issue #41

Locally all tests pass with dependencies upgraded to the minimum and maximum allowed values. Checking to see if they pass on GH. Will test with the api testbed before I request review

@stevenbunting
Copy link
Collaborator Author

picking this back up. Ran test suite on new dependencies. Don't see any significant deviations. Anecdotally uses slightly less memory but not sure if attributable to dependencies.

@aklarfeld aklarfeld self-requested a review August 23, 2024 17:19
@stevenbunting stevenbunting merged commit 4bcc0a7 into master Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants