Feature: Endpoint Categorization including method #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supergood endpoints are categorized using a regex pattern matched against a few options. However, for an endpoint that is queried using multiple methods (GET, POST, PATCH, etc) all these calls get conflated to the same endpoint.
There are some cases where this may be desired, but in general a POST and a GET to an endpoint should not be considered the same. This PR will now allow for an endpoint's method to be specified in the remote config. Calls must match both the regex and the endpoint method now to be considered a match.
Added unit test case, currently testing locally.