Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed domains + New Telemetry Endpoint #34

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

aklarfeld
Copy link
Contributor

@aklarfeld aklarfeld commented Mar 11, 2024

Description: Adding allowed domains back in, currently we only support ignoredDomains.

AllowedDomains overrides any other configuration, if it's populated.

  • Unit Tests pass on 3/11/24
  • Manual Tests by Alex Klarfeld performed on 3/11/24
  • Test Results: Pass
  • Approved & Reviewed by: Steven Bunting & Zachary Benamram on 3/11/24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aklarfeld aklarfeld changed the title Add allowed domains Add allowed domains + New Telemetry Endpoint Mar 11, 2024
baseUrl,
allowLocalUrls,
allowIpAddresses
});

expect(result).toBe(false);
});

it('should return true if allowedDomains is populated and the domain is not in the list', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit "... and the domain is in the list"

@aklarfeld aklarfeld merged commit 5e0859c into master Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants