Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the responses from the google auth API are getting mangled by the Supergood client. I think it has something to do with the responses getting written at the same time. This was causing our own login to fail when we were running the node client on our own instance.
I looked back at the original mswjs interceptor code and noticed that they were cloning the incoming messages so they didn't step on each other:
https://github.com/mswjs/interceptors/blob/122a6533ce57d551dc3b59b3bb43a39026989b70/src/interceptors/ClientRequest/NodeClientRequest.ts#L368
I also noticed we were emitting the same response twice, as on line 125. We had been noticing duplicate events coming through our system and weren't exactly sure where they were coming from. This might be the culprit.
I'm not exactly sure why the responses are getting mangled by Supergood, but cloning them seems to have mitigated the problem.
When I say mangling responses, this is the response passed in when Supergood isn't enabled: