updating tests

supergoodsystems · Aug 14, 2024 · 1cdb0ca · 1cdb0ca
1 parent 9c37cb7
commit 1cdb0ca
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/test/e2e/proxy-axios.e2e.test.ts b/test/e2e/proxy-axios.e2e.test.ts
@@ -34,11 +34,14 @@ describe('proxy axios functionality', () => {
       },
       SUPERGOOD_SERVER
     );
+    // NOTE: currently implementation does not update the protocol
+    // between upstream and proxy
+    // TODO: support protocol differences between upstream + proxy
     await axios.get(`http://api.openai.com/custom-header`);
     await Supergood.close();
     expect(getEvents(postEventsMock).length).toEqual(1);
     expect(getEvents(postEventsMock)[0].request.url).toEqual(
-      'https://api.openai.com/custom-header'
+      'http://api.openai.com/custom-header'
     );
     expect(getEvents(postEventsMock)[0].response.status).toEqual(200);
     expect(

diff --git a/test/e2e/proxy-native-fetch.e2e.test.ts b/test/e2e/proxy-native-fetch.e2e.test.ts
@@ -32,11 +32,14 @@ describe('proxy native fetch functionality', () => {
       },
       SUPERGOOD_SERVER
     );
-    await fetch(`https://api.openai.com/custom-header`);
+    // NOTE: currently implementation does not update the protocol
+    // between upstream and proxy
+    // TODO: support protocol differences between upstream + proxy
+    await fetch(`http://api.openai.com/custom-header`);
     await Supergood.close();
     expect(getEvents(postEventsMock).length).toEqual(1);
     expect(getEvents(postEventsMock)[0].request.url).toEqual(
-      'https://api.openai.com/custom-header'
+      'http://api.openai.com/custom-header'
     );
     expect(getEvents(postEventsMock)[0].response.status).toEqual(200);
     expect(

diff --git a/test/e2e/proxy-node-fetch.e2e.test.ts b/test/e2e/proxy-node-fetch.e2e.test.ts
@@ -34,11 +34,14 @@ describe('proxy node-fetch functionality', () => {
       },
       SUPERGOOD_SERVER
     );
+    // NOTE: currently implementation does not update the protocol
+    // between upstream and proxy
+    // TODO: support protocol differences between upstream + proxy
     await fetch(`http://api.openai.com/custom-header`);
     await Supergood.close();
     expect(getEvents(postEventsMock).length).toEqual(1);
     expect(getEvents(postEventsMock)[0].request.url).toEqual(
-      'https://api.openai.com/custom-header'
+      'http://api.openai.com/custom-header'
     );
     expect(getEvents(postEventsMock)[0].response.status).toEqual(200);
     expect(