WIP tweaks to work better in the browser #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devdoshi
commented
Feb 17, 2024
devdoshi
commented
- autoformatting
- use correct supergood remote config
- use browser crypto
- use msw interceptors for fetch and xhr
- use correct supergood remote config - use browser crypto - use msw interceptors for fetch and xhr
devdoshi
commented
Feb 17, 2024
| ).toString('base64')}`, | ||
| 'Supergood-api': 'supergood-browser', | ||
|
|
||
| authorization: `Basic ${btoa(`${clientId}:${clientSecret}`)}`, |
There was a problem hiding this comment.
- decide on auth approach (requires corresponding backend changes)
devdoshi
commented
Feb 17, 2024
| if (!shouldIntercept) { | ||
| return; | ||
| } | ||
| requestIdsToIntercept.add(requestId); |
There was a problem hiding this comment.
- need to clarify the expected behavior with regard to the remote config. as written, a response could theoretically arrive before the requestId is added to the set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.