fix: insert tolerance into redeemShare() checks [SUP-8853]
#645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTimepunk
changed the title
redeemShare() checks [SUP-8835]redeemShare() checks [SUP-8853]
0xTimepunk
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/yAudit/superform-report/issues/2
deposit4626() is used to redeem vault assets and deposit them in a superform vault. However, in _redeemShare(), there is a strict equality balance check, that, in case of stETH, will always revert.
Technical Details
Lido stETH has a know rounding down problem as stated in their docs. When trying to redeem stETH with deposit4626(), the balance check will always fail leading the function to revert.
Impact
Low. It is not possible to use deposit4626() with a stETH vault and any other token that have a similar behaviour.
Recommendation
Avoid to use strict equality and insert a tolerance in the balance check to handle the 1-2 wei corner case in the same way that is done here.