fix: Add revert for invalid rebalance selector #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTimepunk
approved these changes
Oct 18, 2024
TamaraRingas
deleted the
tamara-sup-8925-fail-sooner-in-completecrosschainrebalance
branch
TamaraRingas
restored the
tamara-sup-8925-fail-sooner-in-completecrosschainrebalance
branch
TamaraRingas
deleted the
tamara-sup-8925-fail-sooner-in-completecrosschainrebalance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the completeCrossChainRebalance() function, there's an if-else block that checks against data.rebalanceSelector. However, if none of the conditions in this block are met, the function continues to execute. The subsequent _deposit call will fail because none of the router function signatures are matched. It would be more gas efficient to fail earlier in this scenario.
Solution
Insert a last else in the if-else block:
else {
revert INVALID_REBALANCE_SELECTOR();
}